Improve and fix GCP CI test #684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlCutter
force-pushed
the
fix_ci
branch
12 times, most recently
from
3801145 to
d218e5d
Compare
AlCutter
force-pushed
the
fix_ci
branch
13 times, most recently
from
f61e888 to
5f58b3f
Compare
phbnf
approved these changes
Jan 28, 2026
Collaborator
There was a problem hiding this comment.
Nit: Should we also destroy the key here to keep everything consistent?
| docker_env = local.env | ||
| base_name = include.root.locals.base_name | ||
| origin_suffix = include.root.locals.origin_suffix | ||
| origin = "${local.base_name}${include.root.locals.origin_suffix}" |
Collaborator
There was a problem hiding this comment.
You can also edit / remove origin_suffix from deployment/live/gcp/static-ct-staging/logs/root.hcl
Collaborator
Author
There was a problem hiding this comment.
I left that there consciously so that the suffix is guaranteed to be common across all the arche logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few changes to the CI set up to fix the breakage and introduce some minor improvements:
generate_keycommand. Previously, incorrectlylogpreceded the origin.origin_suffixvariable withorigin. Previously,originwas passed implicitly asbase_name, andorigin_suffixwas appended in all locations where an origin was required. This change makes it easier to be explicit and consistent about the value of origin across multiple locations.safe_origininternal string for use in naming GCP resources where only alphanumeric and-chars are permitted.generate_keytool is tested.originand use that consistently.